feat: Add luthername max_length + modernize CI#57
Merged
Conversation
When downstream modules append suffixes (e.g., -exec, -role), names can exceed AWS service limits. Add an optional max_length variable that truncates the prefix while preserving the ID suffix for uniqueness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…terns - Dynamic module/example discovery with matrix strategy for parallel validation - Upgrade from hashicorp/terraform:1.5.7 container to hashicorp/setup-terraform@v3 (1.7.5) - Update actions/checkout v3 → v4 - Add push-to-main trigger alongside pull request trigger - Separate jobs for modules, examples, format check, and terraform tests - Use -backend=false for init to avoid backend configuration issues - Support .validate-skip and .tftest.hcl patterns from insideout-terraform-presets Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Skip modules with tests/ dirs from validate-modules (they use provider aliases that can't validate standalone, matching old validate.sh behavior) - Remove validate-examples job (examples use SSH git sources unavailable in CI, matching old validate.sh which excluded examples) - Fix pre-existing formatting in config.tfvars (now caught by -recursive flag) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_length: Add optionalmax_lengthvariable to control generated name length. When set, truncates the prefix while preserving the ID suffix for uniqueness. Solves the problem of names exceeding AWS service limits (64-char IAM roles, 50-char backup rules) when downstream modules append suffixes like-exec,-role,-query-pol.insideout-terraform-presets— dynamic module discovery, matrix-based parallel validation, separate jobs for format/validate/test, upgraded terraform (1.7.5) and actions versions.Closes #56
Test plan
terraform fmt -checkpasses on all modified filesterraform init -backend=false && terraform validatepasses inluthername/max_length=Nproduces output of exactly N chars when raw name exceeds limit🤖 Generated with Claude Code