feat(icon-button): also render label as hidden text inside the button#1674
Draft
gcornut wants to merge 1 commit into
Draft
feat(icon-button): also render label as hidden text inside the button#1674gcornut wants to merge 1 commit into
gcornut wants to merge 1 commit into
Conversation
gcornut
force-pushed
the
feat/icon_button_render_label_as_hidden_text_instead_of_aria_label
branch
from
fa5c669 to
6e0d10f
Compare
gcornut
force-pushed
the
feat/icon_button_render_label_as_hidden_text_instead_of_aria_label
branch
2 times, most recently
from
84b9030 to
633193e
Compare
gcornut
changed the title
gcornut
force-pushed
the
feat/icon_button_render_label_as_hidden_text_instead_of_aria_label
branch
2 times, most recently
from
68a7c9d to
4f74930
Compare
Visual Regression Report@lumx/react — 1 difference(s)@lumx/vue — No changes@lumx/react vs @lumx/vue — 1 difference(s), 462 matched, 123 React-only, 3 Vue-only |
gcornut
force-pushed
the
feat/icon_button_render_label_as_hidden_text_instead_of_aria_label
branch
from
4f74930 to
bd6d90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General summary
Render the IconButton's label as a visually-hidden text node inside the button (in addition to keeping the existing
aria-labelfor backward compatibility).This will be useful when we want the button to also label another element. For example, we could have a dropdown menu attached to a button which is labeled by the button with
aria-labelledby={buttonId}.StoryBook lumx-react: https://922ba94f0--5fbfb1d508c0520021560f10.chromatic.com/
StoryBook lumx-vue: https://922ba94f0--697a023f84e832e23544fb3c.chromatic.com/