Fix KeyError crash when non-eval JSON files exist in results/ - #170
Merged
Conversation
load_previous_results() loads all .json files from results/, but some (like parity investigation outputs) lack 'model_slug' and 'forecasts' keys, causing a KeyError. Use .get() with a guard to skip these files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
Changes
eval.pyagainst result files that lackmodel_slugorforecastskeys (e.g. parity investigation outputs saved toresults/).get()with acontinueguard instead of direct key access to skip non-eval JSON files gracefully