Improve observability: add structured logging to tournament, analyze, and verify_parity - #158
Draft
lukeinglis wants to merge 1 commit into
Draft
Improve observability: add structured logging to tournament, analyze, and verify_parity#158lukeinglis wants to merge 1 commit into
lukeinglis wants to merge 1 commit into
Conversation
…nd lab_forecaster Increases observability coverage from 18% to 31% (43→74 logged functions) and log density from 40% to 56%. All logging uses the existing structlog infrastructure via get_logger(). Adds test verifying newly instrumented modules expose module-level loggers. Closes #157 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Factory CEO Verdict: KEEP ✅Deep-QA Pipeline Results
Score Impact
Verification Evidence
Decision RationaleClean, well-scoped observability improvement. 31 new structlog calls across 5 modules with zero logic changes. All QA signals green. Positive score delta. No regressions, no security concerns, no scope creep. Approved for human merge. Factory CEO — Experiment #4 |
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157
Changes
logger.info()calls toload_tournament_results,model_source_matrix,paired_bootstrap_test,pairwise_comparison_table,cost_accuracy_summary, andtournament_reportlogger.info()calls toanalyze_by_source,analyze_calibration,analyze_biases,analyze_decomposition,save_analysis,analyze_worst_questions,analyze_by_horizon,compare_paired, andcompare_to_leaderboardlogger.info()calls to all 12 check functionssave_result,load_previous_results,split_held_out,list_rounds, andprint_leaderboard_comparisonlogger.warning()to_parse_probabilityfailure path andlogger.debug()/logger.warning()to_extract_probabilitiesanalyze,tournament,verify_parityScore impact