Skip to content

chore: remove esm package - #214

Open
benmccann wants to merge 3 commits into
lukeed:nextfrom
benmccann:rm-esm
Open

chore: remove esm package#214
benmccann wants to merge 3 commits into
lukeed:nextfrom
benmccann:rm-esm

Conversation

@benmccann

Copy link
Copy Markdown

unblocks #212

the esm package doesn't support the node: protocol, so it must be removed in order to support Deno

@codecov-commenter

codecov-commenter commented Sep 3, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9656b12) to head (c2ea20e).
⚠️ Report is 8 commits behind head on next.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              next      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          322       322           
=========================================
  Hits           322       322           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/workflows/ci.yml
strategy:
matrix:
nodejs: [10, 12, 14, 16, 18]
nodejs: [12, 14, 16, 18]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also drop 12,14,16 as they reached eof for while https://endoflife.date/nodejs and add new version like 19, 20, 21?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 and 21 are EOL too. Adding 20 and 22 would be interesting.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd versions are experimental and should never be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants