fix(skins): replace placeholder artwork - #15
Merged
Conversation
Owner
Author
|
Independent verification verdict is PASS+NOTES. I checked PR #15 at head
The patch is ready for release publication and reporter retesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Neon Cat and Retro Cat selectors loaded the right skin IDs, but every bundled PNG was an exact copy of the default artwork. Users could save a skin choice without seeing a visual change.
Scope
The Settings Apply callback, config persistence, skin discovery, and Qt lifecycle code are unchanged.
Blast Radius
This changes the bundled Neon Cat and Retro Cat appearance in the desktop app and tray icon. Default Cat stays unchanged. Matching dimensions preserve the current window and animation geometry.
Verification
python3 -m unittest -q tests.test_skin_manager.TestBuiltInSkinAssets.test_builtin_skin_assets_are_distinct_and_keep_dimensionspasses.test_configbecause this host lacks PyQt5. GitHub Actions installs the project requirements under Python 3.11 and runs the complete suite before packaging.git diff --checkpasses.Closes #10