Skip to content
This repository was archived by the owner on Jun 1, 2021. It is now read-only.

GUI Boilerplate and Computer Case GUI Beginnings#17

Draft
rschulman wants to merge 9 commits into
lucsoft:master-MC1.16from
rschulman:master-MC1.16
Draft

GUI Boilerplate and Computer Case GUI Beginnings#17
rschulman wants to merge 9 commits into
lucsoft:master-MC1.16from
rschulman:master-MC1.16

Conversation

@rschulman

Copy link
Copy Markdown

This draft PR puts in place a few GUI necessities and adds an almost complete case GUI. It does raise some questions about whether we want to make the different case tiers different classes entirely or continue to make them just variables within one class.

@lucsoft lucsoft marked this pull request as draft December 21, 2020 17:05
@lucsoft

lucsoft commented Dec 21, 2020

Copy link
Copy Markdown
Owner

I would like to keep it as variable as there is not really a change between tthe caseses expact the slots

Comment thread src/main/kotlin/li/cli/oc/Components.kt Outdated
Slots are not working properly yet because the `CaseScreenHandler` is seemingly created twice per GUI opening. Once from `CaseEntity` and once from its registration in`Components.kt`. The latter is generic across Case tiers, and so right now passes in 0 for the tier, which causes an array index out of bounds error.
@lucsoft

lucsoft commented Dec 24, 2020

Copy link
Copy Markdown
Owner

Remeber to update this pr i made big changes (every tecblock is now an blockwithentity)

@rschulman

Copy link
Copy Markdown
Author

I'm working on updating it now, but the new CaseEntity doesn't extend BlockEntity directly, so I'm not sure how to override its functions. Right now IDEA is telling me that createMenu (e.g.) overrides nothing. Do you know how I should proceed?

@omixann

omixann commented Jan 5, 2021

Copy link
Copy Markdown

Hm, slots seem to have scaling issues. I tried to fix it with no luck.

@lucsoft

lucsoft commented Jan 5, 2021

Copy link
Copy Markdown
Owner

I look into it after im done with my work related stuff

@omixann

omixann commented Jan 5, 2021

Copy link
Copy Markdown

I'm currently copying code from upstream, let's see if that works!

@omixann

omixann commented Jan 5, 2021

Copy link
Copy Markdown

image
@rschulman expect a PR soon

@rschulman

Copy link
Copy Markdown
Author

Awesome, thanks @jmi2k!

@rschulman

Copy link
Copy Markdown
Author

@jmi2k Just checking in on this. I don't think I've seen a PR from you, unless I'm missing something!

@lucsoft

lucsoft commented Jan 17, 2021

Copy link
Copy Markdown
Owner

Its in https://github.com/jmi2k/OpenComputers/tree/fix-ui
but keep in mind my focus is on OC2

@omixann

omixann commented Jan 17, 2021

Copy link
Copy Markdown

@rschulman can't you see it here? Did I do something wrong? It's the first time I send PR to different repos from the same fork, maybe I messed up something.
@lucsoft what do you mean by OC2?

@lucsoft

lucsoft commented Jan 17, 2021

Copy link
Copy Markdown
Owner

@jmi2k as in the readme i had teamed up with the Creator of OpenComputers to help bring OpenComputers 2 for Forge & Fabric

@omixann

omixann commented Jan 17, 2021

Copy link
Copy Markdown

Wait there is a v2 of OC in the works! That's amazing!

@lucsoft

lucsoft commented Jan 17, 2021

Copy link
Copy Markdown
Owner

Wait there is a v2 of OC in the works! That's amazing!

Yes its now a Linux Computer that has a lua runtime

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants