This repository was archived by the owner on Dec 1, 2017. It is now read-only.
[library] added DesignSpecActivity#2
Open
arok wants to merge 1 commit into
Open
Conversation
Owner
|
Hmm, quite mixed about this one. I'd like to keep it simple. Providing a FrameLayout seems like the right level of convenience to debug existing code in any project. Activities tends to vary more from project to project and are harder to integrate if you have your own base Activity. |
Author
|
I think just the opposite, if you have your own base activity use dspec are more simple. With base class you may setup individual build configuration for debug and using dspec. |
|
What if you have multiple libraries that require you to extend their Activity? This Activity could be an example for users that want to integrate dspec into their base 👍 but doesn't IMHO need to be part of the core library. 👍 for keeping it simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added simple DesignSpecActivity