Skip to content

Add sunset sunrise times #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dstrants wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add sunset sunrise times #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a20f932
added sunrise and sunset times on the gem
Aug 31, 2017
157e3e7
Parsed time bigints to local computer time
Aug 31, 2017
9ca3a88
added the sunrise and sunset functions to the README.md
Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Also you can get some data on the gem response:
* Clouds
* Wind speed
* Wind angle
* Sunrise Time
* Sunset Time

You can get your APP ID from the OpenWeatherMap website.

Expand Down Expand Up @@ -90,4 +92,3 @@ Contributors:
## License

The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

8 changes: 5 additions & 3 deletions lib/openweather2/weather.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module Openweather2
class Weather

attr_reader :city, :longitude, :latitude, :pressure, :humidity, :clouds,
:temperature, :min_temperature, :max_temperature, :wind_speed, :wind_angle
:temperature, :min_temperature, :max_temperature, :wind_speed,
:wind_angle, :sunrise, :sunset

def initialize(json)
@city = json['name']
Expand All @@ -16,6 +16,8 @@ def initialize(json)
@clouds = json['clouds']['all']
@wind_speed = json['wind']['speed']
@wind_angle = json['wind']['deg']
@sunrise = Time.at(json['sys']['sunrise'])
@sunset = Time.at(json['sys']['sunset'])
end
end
end
end