Fix shared PHPStan type safety#250
Merged
Merged
Conversation
Verma-Punit
marked this pull request as ready for review
July 16, 2026 06:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Datahelper.AppServiceProvider::boot()using Laravel's supported provider dependency injection.Why
The hosted Platform runs PHPStan at level 9. After syncing the OSS Alpha 2 baseline, these shared files produced nine type errors even though their runtime tests passed. Keeping the fixes in OSS preserves the shared-runtime ownership boundary and prevents a Platform-only fork.
Impact
No behavior or dependency changes. The changes make existing runtime assumptions explicit and retain the same login, phone placeholder, inline service creation, and validation-reset behavior.
Validation
vendor/bin/pint --dirty --format agent