fix: return 405 for wrong method, scope CORS allowed methods#3
Merged
Conversation
pgagnidze
force-pushed
the
fix/method-handling
branch
4 times, most recently
from
376a339 to
c1e0527
Compare
When a request targets a valid path but uses an unsupported HTTP method, the server now returns 405 with an Allow header listing the actual methods registered for that path, instead of returning 404. The Access-Control-Allow-Methods CORS header now reflects only the methods registered for the requested path (on both preflight and 405 responses), rather than advertising all methods globally. Closes #2
pgagnidze
force-pushed
the
fix/method-handling
branch
from
c1e0527 to
161e591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2 - two issues with HTTP method handling:
405 Method Not Allowedwith anAllowheader listing the registered methods, instead of404 Not Found.Access-Control-Allow-Methodsheader now reflects only the methods actually registered for the requested path (on both preflight and 405 responses), rather than hardcoding all methods globally.Test plan
bustedpasses (3 new tests formethods_for_path)luacheck .andstylua --check .passPUT /heartbeatreturns 405 withAllow: GET, OPTIONSwhen only GET is registeredOPTIONS /heartbeatpreflight returnsAccess-Control-Allow-Methods: GET, OPTIONSGET /nonexistentstill returns 404router.all) continue to match all methods