Skip to content

fix(models): include Muse Spark 1.2 variants in offline vision fallback (#183) - #189

Merged
ltmoerdani merged 1 commit into
ltmoerdani:mainfrom
Fahad090NP:fix/issue-183-muse-vision-fallback
Aug 23, 2026
Merged

fix(models): include Muse Spark 1.2 variants in offline vision fallback (#183)#189
ltmoerdani merged 1 commit into
ltmoerdani:mainfrom
Fahad090NP:fix/issue-183-muse-vision-fallback

Conversation

@Fahad090NP

@Fahad090NP Fahad090NP commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #183

PEACE BE UPON YOU

Summary

Addresses #183 (Muse Spark 1.2 Contributor Free on Zen + images). Two parts:

1. Already fixed in 0.7.0 — please upgrade. The reporter's stack trace is from v0.6.0, where muse-spark-1.2-contributor-free went through the chat-completions endpoint — which the Muse gateway rejects (that's why the 400 body is a chat.completion object with an empty message and finish_reason: null). Commit 5586836 (released in 0.7.0) routes all muse-* models to the Responses API, and images are mapped to the correct input_image shape there.

2. This PR — offline vision fallback gap. models.dev lists image/video/pdf/audio input modalities for both Muse variants, but VISION_CAPABLE_MODELS (the bundled fallback used when neither live metadata nor a cached models.dev snapshot is available) lacked them. In that state the picker reported imageInput: false, so VS Code stripped image attachments before they ever reached the provider. Both variants are now in the set, so offline/cold-start users can attach images to Muse models too.

Verification

  • npm run lint all 7 checks green; new assertion covers both variants.
  • 2 files changed, +11.

Fi Amanillah

…ck (ltmoerdani#183)

models.dev lists image/video/pdf/audio input modalities for both
muse-spark-1.2-contributor and -free, but VISION_CAPABLE_MODELS (the offline
fallback) lacked them — so when neither live metadata nor the models.dev
snapshot was available, the picker reported imageInput: false and VS Code
stripped image attachments before they reached the provider.

Note: the primary ltmoerdani#183 scenario (v0.6.0 sending muse through
chat-completions) was already fixed by 5586836, which routes muse to the
Responses endpoint in 0.7.0+.
@ltmoerdani

Copy link
Copy Markdown
Owner

nice one, verified locally and this checks out.

What I confirmed on my end:

  • checked out your branch and ran npm run lint, all 7 checks green including the new assertions
  • the gap is real: fallbackModelMetadata does an exact-match lookup against VISION_CAPABLE_MODELS, so on cold start with no live metadata and no cached models.dev snapshot, both Muse variants would report imageInput: false and VS Code drops image attachments before we see them
  • agreed the primary [BUG] Muse Spark 1.2 Contributor Free on OpenCode Zen does not work with images #183 case was the v0.6.0 chat-completions routing, already handled by 5586836 in 0.7.0. this covers the fallback edge case that was still open

Small comment on the diff itself: the contract note you added above the two entries is helpful, no change requested there.

Merging this now. Thanks for keeping the offline fallback path in mind, most people only test with live metadata available.

@ltmoerdani
ltmoerdani merged commit dd4fefb into ltmoerdani:main Aug 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Muse Spark 1.2 Contributor Free on OpenCode Zen does not work with images

2 participants