DM-55061: Calculate default value of dbauth_alias#144
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 84.83% 84.90% +0.07%
==========================================
Files 73 73
Lines 7385 7408 +23
Branches 847 850 +3
==========================================
+ Hits 6265 6290 +25
+ Misses 883 881 -2
Partials 237 237 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Adds support for deriving a default dbauth_alias for Cassandra db-auth credential lookup when the alias is not explicitly configured, enabling automatic selection of prod/dev credential entries based on username and keyspace.
Changes:
- Added
ApdbCassandraConfig.get_dbauth_alias()to compute a default alias whenconnection_config.dbauth_aliasis empty. - Updated
SessionFactory._make_auth_provider()to use the computed alias (when available) with higher priority than contact points. - Extended Cassandra db-auth tests to cover the new derived-alias behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_apdbCassandra.py |
Adds db-auth fixtures and assertions to validate derived alias lookup behavior. |
python/lsst/dax/apdb/cassandra/sessionFactory.py |
Switches db-auth host selection to use computed alias via config helper. |
python/lsst/dax/apdb/cassandra/config.py |
Introduces get_dbauth_alias() and updates dbauth_alias field description to document defaulting behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
95d0d20 to
91b6224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.