Remove support for the SGE (Sun Grid Engine) launcher#190
Open
AlexJones0 wants to merge 1 commit into
Open
Conversation
This PR drops support for the legacy SGE (Sun Grid Engine) launcher. The motivations for this are as follows: - This launcher is a legacy implementation intended to be replaced by a new async runtime backend implementation, which can more efficiently amortize operations around operations on many jobs at once. - We currently have no easy method for testing the implementation of this launcher. Changes to DVSim can break the launcher without realising. - The launcher already seems to be in a broken state after other refactors & changes, and there are no current users of the launcher to the best of my knowledge. - In the event that the functionality originally implemented by this launcher is desired again, the best solution would instead be to implement a new runtime backend interface for the launcher. The history of this launcher can be used as a reference for such an implementation if useful, as opposed to carrying around this unused, untestable legacy code. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
machshev
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops support for the legacy SGE (Sun Grid Engine) launcher.
The motivations for this are as follows:
In the event that the functionality originally implemented by this launcher is desired again, the best solution would instead be to implement a new
RuntimeBackendfor the launcher. The Git history of this launcher can be used as a reference for such an implementation if useful, as opposed to carrying around this unused & untestable legacy code.