Add Asset_instance_id to notification reward asset#471
Merged
kirre-bylund merged 2 commits intoJun 1, 2026
Conversation
kirre-bylund
force-pushed
the
feature/1154-add-asset-instance-id-to-notifications
branch
from
00e3f90 to
17aa793
Compare
kirre-bylund
deleted the
feature/1154-add-asset-instance-id-to-notifications
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Asset_instance_id(int?) toLootLockerNotificationRewardAssetso SDK consumers can correlate a reward notification with the granted inventory entry.The field is
nullwhen no instance was created (e.g. group rewards).Also adds
Assert.IsNotNull(rewardBody.Asset.Asset_instance_id)to the existing notification test, and activates the test asset before creating the reward so the grant actually produces an instance.Closes #1154