feat(core): flat models[] config + internal field migration (PR 1 of 3)

[loopingz]

Summary

First of three PRs for the Repository concept refactor. This PR introduces the flat models: string[] parameter on StoreParameters, migrates Store internals from _model/_modelMetadata/_modelType to _models[]/_modelMetadatas Map, and updates downstream stores (fs, postgres, runtime) to match.

Spec: docs/superpowers/specs/2026-05-09-repository-design.md (local-only — gitignored).
Plan: docs/superpowers/plans/2026-05-09-repository-design.md (local-only — gitignored).

What's in this PR (Tasks 1–5 of 8)

• Task 1 — StoreParameters accepts models: string[] alongside legacy model + additionalModels; deprecation WARN log fires on legacy use; ambiguity guard throws when both shapes are set.
• Task 2 — Store class migrated to _models: ModelClass[] and _modelMetadatas: Map<string, ModelMetadata>. _modelType dropped. New getModels() accessor; getModel() deprecated. computeParameters() rewritten to walk parameters.models[]. Latent bug fixed in recursive() subclass walker (the runtime type from Application.setModelMetadata is (string | ModelClass)[], not string[] as the type declared).
• Task 3 — FileStore._get() strict-mode __type check rewritten to use _modelsHierarchy (replaces dropped _modelType reference).
• Task 4 — PostgresStore.resolveTable() migrated off _modelMetadata; parameters.table now treated as a single-model shortcut, with WARN log when set with multiple models.
• Task 5 — Final _model/_modelType references in fs/filestore.ts:205, fs/filestore-unit.spec.ts:299, runtime/invitationservice.spec.ts:100 migrated.

What's not in this PR (deferred)

• Task 6 (migrate spec configs from model: to models:) — cosmetic; deprecation shim keeps existing configs working.
• Task 7 (regenerate webda.module.json schemas) — surfaced a load-bearing regression where the legacy model: { default: "Webda/CoreModel" } schema default is essential for framework-loaded stores to claim every model. Reverted in commit ce6f4112. Needs a follow-up architectural fix.
• Task 8 (final verification) — pending Task 7.

PRs 2 (Repository event re-emission) and 3 (API positioning / docs) follow this one.

Backward compatibility

• All existing { model: "X", additionalModels: [...] } configs keep working via the deprecation shim. A WARN log fires once per service noting the migration path.
• getModel() still returns the first model for back-compat (marked @deprecated).
• useStore() is unchanged in this PR.

Test plan

• pnpm --filter @webda/core test — 554 passed, 1 todo (was 550 before this PR; 4 new tests added).
• pnpm --filter @webda/fs test — 123 passed (was 122; 1 new strict-mode test).
• pnpm --filter @webda/postgres test — 3 new resolveTable tests pass; pre-existing PostgresStoreSmokeTest failures unrelated (DB connectivity).
• CI build green (TBD on push).

How this was built

Each task: TDD (failing test → implementation → passing test → commit). Two-stage subagent review per task (spec compliance, then code quality), with fix loops where reviewers found issues. Two follow-up commits for code-review feedback land on top of the original task commits where applicable.

🤖 Generated with Claude Code

---

Update — PR 1 completed (Tasks 6–8)

The three deferred tasks are now done; PR 1 is feature-complete.

• Task 6 (spec config migration) — migrated the canonical Store configs in core (memory, coremodel, oauth), fs (filestore) and postgres (smoke) specs from { model: "X" } to { models: ["X"] }. Deprecated-shape coverage is retained: memory.spec additionalModels(), filestore-unit loadParameters(), and the StoreParameters.load() compat-matrix unit tests still exercise the legacy model + additionalModels path. Added MemoryLogger-based assertions that the deprecation WARN fires on legacy input and stays silent on models[].

• Task 7 (schema regeneration) — the "load-bearing regression" was a phantom. Investigated the feared model: { default: "Webda/CoreModel" } default: the compiler-generated loadParameters() builds params via new StoreParameters().load(data) with no JSON-schema default injection, and service creation does no boot-time schema validation — so that default was documentation-only and never claimed models at runtime. Confirmed empirically (core was already regenerated and all tests pass). Force-regenerated the stale fs/postgres/runtime schemas (webdac skips regen when a package's own source digest is unchanged, so packages that merely inline StoreParameters never picked up the change). Legacy { model: "X" } configs keep working through the load() shim regardless.

  • aws/gcp/mongodb are out of scope: untouched by this branch and currently non-compiling for pre-existing/unrelated reasons (type drift, incomplete worktree deps). Their schemas remain stale as before this PR.

• Task 8 (verification) — @webda/core 559 passed / 1 todo (store.ts coverage up to 84.8% stmts, 71.4% fns, 89.2% lines), @webda/fs 123 passed, @webda/postgres resolveTable/non-DB tests pass (the 21 failures are pre-existing ECONNREFUSED — no local Postgres). Lint and prettier clean on touched packages; in-scope packages build clean. Also removed the now-obsolete parameters.models = [...] test workarounds that only existed to compensate for the pre-Task-7 stale schema.

Note on backward compatibility

Commit 082ca41b removed the deprecated model / additionalModels typed fields and getModel() from StoreParameters/Store, keeping only the load() input shim. Runtime back-compat for legacy configs is preserved by that shim. Because store schemas use additionalProperties: false, the regenerated schema no longer lists model/additionalModels, so the config UI / tooling would flag a legacy model: config — runtime is unaffected. This matches the direction set by 082ca41b.

[loopingz]

Task 7 (schema regen) — investigation update

After ~30 min of debugging the regression, found that running pnpm exec webdac build --force in packages/core regenerates webda.module.json such that Store.init() is no longer invoked for the Registry MemoryStore in test mode. As a result Store.computeStores() never runs and no Repository is registered for RegistryEntry, breaking 8 tests (CoreTest > registry, CoreTest > cov, CryptoServiceTest > *).

The schema diff itself looks superficially benign:

• additionalModels/model lose default: ... (instead get deprecated: true)
• A new models field is added with default: []

Things ruled out:

• The models field's default value is not the trigger — restoring Webda/CoreModel as the model default did not fix it.
• required array is unchanged for MemoryStore ([type] only).
• MemoryStore's Configuration / Import paths in moddas are correct after regen.
• Direct pnpm exec vitest run shows the same failure with intact schema (3843 lines), so no test-time corruption is at play.

Best guess: when both legacy model and new models fields are deprecated/added in the schema, something downstream in service registration / Modda lookup silently drops the Registry binding. Needs deeper trace through unpackedapplication.loadWebdaModule and Core.createService to confirm.

For now, Task 7 is reverted via fa27845b and the branch is clean (554/554 core tests pass). Tasks 1–5 are independently shippable thanks to the deprecation shim — schema regen + Tasks 6/8 will follow in a separate PR once the root cause is identified.

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.02%. Comparing base (9f0155f) to head (30f9baf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/core/src/stores/store.ts	78.72%	4 Missing and 6 partials ⚠️
packages/postgres/src/postgresstore.ts	33.33%	1 Missing and 1 partial ⚠️
packages/fs/src/filestore.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   73.91%   74.02%   +0.11%     
==========================================
  Files         229      229              
  Lines       15603    15610       +7     
  Branches     3788     3790       +2     
==========================================
+ Hits        11533    11556      +23     
+ Misses       2982     2967      -15     
+ Partials     1088     1087       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.