combobox: Add value-based selection API#2576
Open
suxiaoshao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2575
Description
Adds
ComboboxState::set_selected_valuesto resolve values through the current delegate and replace the committed selection without emitting user-originated events. This keeps programmatic selection aligned afterset_items, synchronizes the adapter snapshot, ignores unknown values, and preserves caller order.Includes focused tests for current delegate resolution, missing and empty values, snapshot synchronization, and event behavior, plus English and Simplified Chinese documentation.
How to Test
cargo check -p gpui-component --testscargo clippy -p gpui-component --all-targets -- --deny warningsrustfmt --edition 2024 --check crates/ui/src/combobox.rsgit diff --checkChecklist