ui: Use popover background for dropdown menus#2574
Open
sh4den wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select and Combobox paint their dropdown menu panel with
tokens.background,while PopupMenu and Popover use
tokens.popover. With a theme that has atranslucent background color (transparent window setups), open select menus
become see-through and hard to read while every other floating panel stays
opaque.
This paints both menus with
tokens.popoverand its pairedpopover_foreground, the same pairpopover_style()uses, so they match therest of the popups. In the default themes
popoverfalls back tobackground, so nothing changes visually there. No API changes.Screenshot
How to Test
Run
cargo runand open the Select and Combobox stories, menus should lookunchanged with the default themes (
backgroundandpopoverare the samecolor there). To see the fix, set the theme's
backgroundto a translucentcolor and open a select menu: it stays opaque instead of showing the content
behind it.
Checklist
cargo runfor story tests related to the changes.