input: Skip highlighting for plain text and unregistered languages#2567
Merged
Conversation
huacnlee
reviewed
Jul 14, 2026
|
|
||
| let (language, query, injection, locals) = match self { | ||
| Self::Plain => (tree_sitter_json::LANGUAGE, "", "", ""), | ||
| Self::Plain => unreachable!(), |
Contributor
Author
There was a problem hiding this comment.
Replaced it with debug_assert
Contributor
Author
There was a problem hiding this comment.
Removed the added matches! instead and just return the new plain config in the original match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2566
Description
Plain text and other unregistered languages, like a code fence in markdown, falls back to JSON currently. Which is a lot of unnecessary parsing, and also causes quite a big memory overhead.
Screenshot
How to Test
I've also checked various other files in the editor example
Checklist
cargo runfor story tests related to the changes.