settings: Use vertical layout when container is small#2564
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
huacnlee
changed the title
huacnlee
enabled auto-merge (squash)
July 13, 2026 11:05
GPUI now stretches auto-sized window roots to the viewport. Keep the auto-height panel under an explicit viewport root so the test continues to exercise descendant intrinsic sizing. Co-authored-by: Codex <codex@openai.com>
huacnlee
disabled auto-merge
July 13, 2026 11:31
huacnlee
enabled auto-merge (squash)
July 13, 2026 11:31
boboshan
added a commit
to neath-audio/gpui-component
that referenced
this pull request
Jul 14, 2026
…idge#2564)" This reverts commit b004e59.
boboshan
added a commit
to neath-audio/gpui-component
that referenced
this pull request
Jul 14, 2026
Upstream longbridge#2564 (settings vertical-small layout) uses gpui::container_query, added after the previous pin c545fb67. Bump the fork's gpui pin to the rev upstream's Cargo.lock resolves so the merged tree compiles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use GPUI
container_queryon the settings content panel to make setting fields responsive to their available width. At 480px or narrower, horizontal title/field rows switch to a stacked vertical layout while explicitly vertical items remain unchanged. The resolved layout is also passed to field renderers.The GPUI update also makes auto-sized window roots fill the viewport. Update the scrollable auto-height test fixture so the simulated dialog panel is a descendant of an explicit viewport root, matching real application structure.
How to Test
cargo check -p gpui-componentcargo test -p gpui-component --lib— 313 passedChecklist
cargo runfor story tests related to the changes.