Skip to content

Use Zone SDK to bridge assets#348

Open
kashepavadan wants to merge 4 commits into
mainfrom
zone-sdk-bridging
Open

Use Zone SDK to bridge assets#348
kashepavadan wants to merge 4 commits into
mainfrom
zone-sdk-bridging

Conversation

@kashepavadan

Copy link
Copy Markdown
Contributor

@weboko weboko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dogfooded by reading through the tutorial as a Zone SDK user on Linux x86_64, cross-referencing every code example against the actual zone-sdk source in the logos-blockchain repo (crate logos-blockchain-zone-sdk, alias lb-zone-sdk). All method signatures verified. Found several blocking issues: a missing step in the numbering, a non-existent prerequisite file, two code-level bugs in the key-generation block, and a typo.


- A running Logos Blockchain node reachable over HTTP
- The Zone SDK (`lb_zone_sdk`) and `lb_core` crates added to your project
- Completed the [Zone SDK inscription tutorial](./inscribe-data-using-the-zone-sdk.md)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prerequisite file inscribe-data-using-the-zone-sdk.md does not exist in the repository.

A reader cannot complete this stated prerequisite. Either create the inscription tutorial first, or remove/replace this prerequisite until it exists.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware. This is meant to stay as a placeholder until I get that doc in

Comment thread docs/blockchain/zone-sdk/bridge-assets-between-blockchain-and-zone.md Outdated
Comment thread docs/blockchain/zone-sdk/bridge-assets-between-blockchain-and-zone.md Outdated
Comment thread docs/blockchain/zone-sdk/bridge-assets-between-blockchain-and-zone.md Outdated
Comment thread docs/blockchain/zone-sdk/bridge-assets-between-blockchain-and-zone.md Outdated
Comment thread docs/blockchain/zone-sdk/bridge-assets-between-blockchain-and-zone.md Outdated
Co-authored-by: Sasha <118575614+weboko@users.noreply.github.com>

### Option 1: Submit a single-sequencer withdrawal

A withdrawal is initiated inside the zone and lands on-chain as a signed [`ChannelWithdraw`](https://app.notion.com/p/nomos-tech/1-5-0-Mantle-33d261aa09df8051b0d0cd4d5ddade85?source=copy_link#5de261aa09df8321b05401f2e8dea08b) operation. This step applies only when `ChannelState.withdraw_threshold == 1`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep using Notion links from our Github? Can't we have blockchain related docs on GH?

Secondary, nomos-tech in the URL looks weird given we already operate using Logos branding.

cc @fryorcraken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants