More colorations#246
Open
donnyh13 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that after fixing the Function declaration token issue, you added some more tokens to be recognized, such as send keys, etc. I'm not sure how exhaustive you intend it to be, but I wondered about adding a few more? e.g.:
Of course this list could be extended, as there could be built in or user functions found in a function declaration parameter.
🔗 Linked GitHub Issues
Closes #<number>
📋 What is the current behavior?
Currently Boolean, keywords, and numbers, etc are not tokenized to other than meta.function.autoit.
🚀 What is the new behavior?
With these changes Keywords, Boolean, Logical operators, numbers, brackets, comma, dot, concatenation, and assignment operators are now tokenized as normal.
Type of changes
Breaking changes 🔥
How and where was this tested?
Tested on a couple of AutoIt scripts personally.
🖥️ Describe where you tested your changes
System:
Context:
🔬 Describe how you tested your changes
Checklist
Additional context
Screenshots
Note to reviewers