Skip to content

More colorations#246

Open
donnyh13 wants to merge 6 commits into
loganch:masterfrom
donnyh13:more-colorations
Open

More colorations#246
donnyh13 wants to merge 6 commits into
loganch:masterfrom
donnyh13:more-colorations

Conversation

@donnyh13
Copy link
Copy Markdown

Description

I noticed that after fixing the Function declaration token issue, you added some more tokens to be recognized, such as send keys, etc. I'm not sure how exhaustive you intend it to be, but I wondered about adding a few more? e.g.:

  • "constant.language.autoit"
  • "constant.numeric.autoit"
  • "keyword.operator.assignment.autoit"
  • "punctuation.bracket.autoit"
  • "punctuation.commadot.autoit"
  • "keyword.operator.concatenation.autoit"
  • "keyword.operator.logical.autoit"
    Of course this list could be extended, as there could be built in or user functions found in a function declaration parameter.

🔗 Linked GitHub Issues

Closes #<number>

📋 What is the current behavior?

Currently Boolean, keywords, and numbers, etc are not tokenized to other than meta.function.autoit.

🚀 What is the new behavior?

With these changes Keywords, Boolean, Logical operators, numbers, brackets, comma, dot, concatenation, and assignment operators are now tokenized as normal.


Type of changes

  • 🪲 Bugfix (change which fixes an issue)
  • ⭐ New Feature (change which adds functionality)
  • 🔒 Security fix (change which improves security)
  • 🔮 Code style update (formatting, renaming)
  • 🔨 Refactoring (code optimization without functional change)
  • 📚 Documentation (updates to README or docs)
  • ⚙️ Build or CI related changes
  • 🧿 Other type

Breaking changes 🔥

  • Yes
  • No

How and where was this tested?

Tested on a couple of AutoIt scripts personally.

🖥️ Describe where you tested your changes

System:

  • Windows 11 (x64)
  • Windows 10 (x64)
  • Windows 10 (x86)
  • other Windows version
  • other operating system

Context:

  • in Browser <name and version>
  • with Go <version>
  • with Node.js <version>
  • with AutoIt <version> 3.3.18.0
  • with .NET (C#) <version>
  • with ...

🔬 Describe how you tested your changes

  • Manually tested in system and context shown above
  • Ran automatic tests (unit tests, integration tests, etc.)
  • Other ways

Checklist

  • I have read and understood the available contributing guidelines.
  • I have ensured my code follows the available code conventions.
  • I have reviewed my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • I have added/updated necessary tests to cover the changes (if applicable).
  • I have checked for potential security implications.

Additional context

Screenshots

Note to reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant