Skip to content

semantic search experiment#4704

Draft
khalil-akremi wants to merge 2 commits into
lockbook:masterfrom
khalil-akremi:my-search-pr
Draft

semantic search experiment#4704
khalil-akremi wants to merge 2 commits into
lockbook:masterfrom
khalil-akremi:my-search-pr

Conversation

@khalil-akremi

Copy link
Copy Markdown

No description provided.

@Parth Parth changed the title My search pr semantic search experiment Jun 6, 2026
@Parth

Parth commented Jun 6, 2026

Copy link
Copy Markdown
Member

👋 what's the difference between this and #4694? Also, consider keeping your PRs as drafts until they're actually ready for review.

@khalil-akremi

Copy link
Copy Markdown
Author

Thanks for the feedback.

This PR implements semantic search using USearch for vector similarity and nearest-neighbor retrieval. My understanding is that #4694 was based on an earlier attempt that ran into issues because my fork was out of date with the main branch, which led to merge conflicts. This PR contains the updated and corrected implementation.
I'm currently working on a follow-up improvement to support multiple embedding models instead of a single text embedding model.
Thanks for the suggestion regarding draft PRs as well , I'll keep future work as drafts until they're ready for review.

@Parth

Parth commented Jun 6, 2026

Copy link
Copy Markdown
Member

If the older PR is no longer relevant you can close it, you can still convert this PR to a draft
image

@khalil-akremi
khalil-akremi marked this pull request as draft June 6, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants