Surface persistence in start and status commands#244
Open
gtsiolis wants to merge 2 commits into
Open
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
Collaborator
|
@gtsiolis can you open separate PRs for the other changes? There seem to be some changes about the displayed host and some snowflake header changes? Not sure. It's a little hard to read at the moment. |
Member
Author
|
Makes sense. I had a feeling I would have to split this one, will split later. ⏳ |
gtsiolis
force-pushed
the
des-230-surface-persistence-state-in-status-and-start-commands
branch
from
79e001f to
b046e9b
Compare
gtsiolis
force-pushed
the
des-230-surface-persistence-state-in-status-and-start-commands
branch
from
b046e9b to
dfac5a0
Compare
Member
Author
|
Updated PR to include only the Persistence metadata in the header without additional cleanup, plus show the metadata only for AWS emulation. Curious what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Persistence: Enabledbullet to the start info block and the status output when the running instance hasLOCALSTACK_PERSISTENCE=1set — either via--persistor by inheriting the env var from the host shell. restart benefits transitively since it dispatches through start.