Add snapshot save command (local)#210
Merged
anisaoshafi merged 26 commits intoMay 13, 2026
Merged
Conversation
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
4 times, most recently
from
f6bbfbf to
6a24cdf
Compare
Member
|
I've posted a comment[1] in PRO-212 to discuss some potential changes, comments welcome! |
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
from
19cab09 to
cc8b494
Compare
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
5 times, most recently
from
e2a83f0 to
b09a963
Compare
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
from
36170a5 to
7e45925
Compare
anisaoshafi
changed the title
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
2 times, most recently
from
cc13c98 to
c680041
Compare
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
from
570047a to
e5dfa92
Compare
Collaborator
Author
|
@gtsiolis would really appreciate your UX input when you have time to test this 🙏🏼 |
Member
|
Looking at this now! 👀 |
gtsiolis
approved these changes
May 12, 2026
| defer func() { | ||
| sink.Emit(output.SpinnerStop()) | ||
| if retErr == nil { | ||
| sink.Emit(output.MessageEvent{Severity: output.SeveritySuccess, Text: fmt.Sprintf("Snapshot saved to %s", dest)}) |
Member
There was a problem hiding this comment.
praise: Nice! 🤩 Adding some screenshots for future reference.
| Saving Snapshot | Saved Snapshot |
|---|---|
 |
 |
gtsiolis
reviewed
May 12, 2026
Member
gtsiolis
left a comment
gtsiolis
left a comment
There was a problem hiding this comment.
Missed one important question before.
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
from
c7c3f05 to
6bb4d82
Compare
Without this, a failed io.Copy left a corrupt/partial ZIP on disk. The user had no indication the file was incomplete. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Passing nil to runLstk inherited the developer's real $HOME, which could write to ~/.config/lstk/lstk.log and the file-keyring fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Verify that ErrorEvent is routed to errOut and all other events go to out, and that nil writer arguments fall back safely without panicking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix AWS-only guard to correctly reject non-AWS emulator configs, align container lookup with the for-loop pattern used in aws.go, route ErrorEvents to stderr via NewPlainSinkSplit, and minor code clarity improvements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
anisaoshafi
force-pushed
the
drg-764-migrate-state-commands-from-cli-v1-export
branch
from
fd56fac to
60503f4
Compare
Member
|
That's one small step for snapshots, one giant leap for LocalStack. 💿 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new snapshot subcommand with an initial save action that saves the current LocalStack state to a snapshot file.
Scope for this PR is saving a snapshot locally.
Saving remotely coming next.