Skip to content

ReadyForRoomEvent#666

Open
stephen-derosa wants to merge 1 commit into
mainfrom
sderosa/BOT-344-ready-for-room-event
Open

ReadyForRoomEvent#666
stephen-derosa wants to merge 1 commit into
mainfrom
sderosa/BOT-344-ready-for-room-event

Conversation

@stephen-derosa
Copy link
Copy Markdown

Overview

Send ReadyForRoomEventRequest once async connection is returned from rust.

Implications

Without this as of this commit in the rust SDK after fulfilling the async connection response, rust will timeout with a panic after 1s of not getting this request

@stephen-derosa stephen-derosa requested review from ladvoc and lukasIO May 20, 2026 22:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

⚠️ No Changeset found

Latest commit: 395fe98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@stephen-derosa
Copy link
Copy Markdown
Author

looks like my prettier stage is failing, i ran it locally but i see its unchanged -- maybe my local prettier format (default) is not what the repo uses?

❯ pnpm exec prettier --check "packages/livekit-rtc/src/room.ts"
Checking formatting...
All matched files use Prettier code style!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant