fix(browser): fix annotation jump position in fit-to-width mode#261
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Apr 20, 2026
Merged
Conversation
Move m_lastScaleFactor assignment after scale mode adjustment in deform() to ensure it reflects the actual rendering scale factor. 修复注释跳转位置偏下的问题,将 m_lastScaleFactor 赋值移到 缩放模式调整之后,确保使用实际渲染缩放比例计算跳转位置。 Log: 修复注释跳转位置不正确 PMS: BUG-311189 Influence: 修复在适应页宽等模式下点击注释列表跳转时,跳转位置偏下导致注释不可见的问题。
2b08eba to
b09b12a
Compare
deepin pr auto review这段代码修改主要涉及版权年份更新和 1. 语法逻辑审查修改内容分析:
潜在问题:
建议:
2. 代码质量审查优点:
改进建议:
3. 代码性能审查
4. 代码安全审查
5. 其他建议
修改后的代码建议(添加注释):// 在处理完缩放模式后更新最后的缩放因子
m_lastScaleFactor = operation.scaleFactor;总结这段修改总体是合理的,但需要确认 |
lzwind
approved these changes
Apr 20, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move m_lastScaleFactor assignment after scale mode adjustment in deform() to ensure it reflects the actual rendering scale factor.
修复注释跳转位置偏下的问题,将 m_lastScaleFactor 赋值移到
缩放模式调整之后,确保使用实际渲染缩放比例计算跳转位置。
Log: 修复注释跳转位置不正确
PMS: BUG-311189
Influence: 修复在适应页宽等模式下点击注释列表跳转时,跳转位置偏下导致注释不可见的问题。