Skip to content

feat: add libdde-shell-dock package#1587

Merged
BLumia merged 2 commits intolinuxdeepin:masterfrom
lhdjply:add/libdde-shell-dock
May 7, 2026
Merged

feat: add libdde-shell-dock package#1587
BLumia merged 2 commits intolinuxdeepin:masterfrom
lhdjply:add/libdde-shell-dock

Conversation

@lhdjply
Copy link
Copy Markdown
Contributor

@lhdjply lhdjply commented May 7, 2026

Summary by Sourcery

Add Debian packaging for the libdde-shell-dock runtime library and update the corresponding -dev package.

New Features:

  • Introduce a libdde-shell-dock binary package to distribute the runtime library.

Build:

  • Update debian/control and install manifests to define and install files for the libdde-shell-dock and libdde-shell-dock-dev packages.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lhdjply

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

Hi @lhdjply. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown

Hi @lhdjply. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds Debian packaging for a new libdde-shell-dock binary and adjusts associated dev package install rules.

File-Level Changes

Change Details Files
Introduce runtime libdde-shell-dock Debian package alongside existing dev package.
  • Add a new debian/libdde-shell-dock.install file to define installed runtime library artifacts
  • Adjust debian/control to declare the libdde-shell-dock binary package and its metadata (dependencies, description, section, etc.)
  • Keep debian/libdde-shell-dock-dev.install for development files, separating them from the new runtime package contents
debian/control
debian/libdde-shell-dock-dev.install
debian/libdde-shell-dock.install

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lhdjply lhdjply force-pushed the add/libdde-shell-dock branch from f174284 to 8166b38 Compare May 7, 2026 02:51
Copy link
Copy Markdown
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样打包后升级上来会有问题吧?应该需要给 Package: libdde-shell-dock 加这么一节:

Breaks:
 libdde-shell-dock-dev (<< 2.0.39),
Replaces:
 libdde-shell-dock-dev (<< 2.0.39),

不然从有问题的版本升级会有类似下面的错误:

正试图覆盖 /usr/lib/x86_64-linux-gnu/libdde-shell-dock.so.1,它同时被包含于软件包 libdde-shell-dock-dev 2.0.38

@lhdjply lhdjply force-pushed the add/libdde-shell-dock branch from 8166b38 to 41c94f3 Compare May 7, 2026 03:00
@lhdjply
Copy link
Copy Markdown
Contributor Author

lhdjply commented May 7, 2026

I have read the CLA Document and I hereby sign the CLA.

deepin-bot Bot added a commit to linuxdeepin/cla that referenced this pull request May 7, 2026
Signed-off-by: lhdjply <lhdjply@126.com>
@lhdjply lhdjply force-pushed the add/libdde-shell-dock branch from 41c94f3 to 30599e1 Compare May 7, 2026 03:11
Comment thread debian/libdde-shell-dock.install Outdated
@BLumia BLumia merged commit dd51205 into linuxdeepin:master May 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants