Skip to content

Add build script for pandas 2.2.3#84

Open
pranjalpatidar01 wants to merge 5 commits into
linux-on-ibm-z:mainfrom
pranjalpatidar01:pandas-2.2.3
Open

Add build script for pandas 2.2.3#84
pranjalpatidar01 wants to merge 5 commits into
linux-on-ibm-z:mainfrom
pranjalpatidar01:pandas-2.2.3

Conversation

@pranjalpatidar01
Copy link
Copy Markdown

Summary

Added build script support for pandas 2.2.3.

Included files

  • build_pandas.sh
  • LICENSE
  • pandas_2.2.3.json

Validation

  • Successfully built pandas 2.2.3 wheel
  • Verified installation
  • Tested on supported platform

Comment thread p/pandas/build_info.json
@@ -0,0 +1,16 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file name is not proper, it should be build_info.json

@namrata-ibm
Copy link
Copy Markdown
Contributor

@pranjalpatidar01 the PR needs multiple changes, please correct the file names, folder structure, script format.
Refer other scripts in this repo : eg https://github.com/linux-on-ibm-z/build-scripts/tree/main/y/yarl

@pranjalpatidar01
Copy link
Copy Markdown
Author

I’ve updated the PR with the requested changes:

  1. Corrected folder structure
  2. Updated file names
  3. Aligned script format with existing repo conventions

Comment thread p/pandas/build_info.json Outdated
"docker_build": false,
"validate_build_script": true,
"use_non_root_user": "false",
"v0.2.*": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version should be v2.2.* to match the package version

@namrata-ibm
Copy link
Copy Markdown
Contributor

@pranjalpatidar01 the script file is still not aligned as per the requirement. Please compare with existing scripts in this repo and update.

@pranjalpatidar01
Copy link
Copy Markdown
Author

Hi @namrata.bhave, I’ve updated the script and build_info.json to align with the existing repository conventions, corrected the naming/folder structure, and validated the build and test execution on UBI/RHEL 9.6 (s390x). Could you please review again when you get a chance.

@sankalp-sde
Copy link
Copy Markdown
Contributor

@pranjalpatidar01 Please update your script file to match the existing format. Refer to this example:

# Package : async
# Version : v3.2.5
# Source repo : https://github.com/caolan/async.git
# Tested on : UBI:9.3
# Language : JavaScript
# Ci-Check : True
# Script License : Apache License, Version 2 or later
# Maintainer : Sankalp <Sankalp@ibm.com>

@pranjalpatidar01
Copy link
Copy Markdown
Author

Hi @sankalp-sde , I’ve updated the pandas script header and formatting to align with the existing repository conventions and pushed the latest changes. Could you please review again when you get a chance.

@sankalp-sde
Copy link
Copy Markdown
Contributor

@pranjalpatidar01 The distro handling and overall script structure do not align with the repository conventions for platform-specific scripts. it should ideally be scoped to the intended target platform instead of handling multiple Ubuntu, RHEL, and SLES variants in the script

Please refer to the existing scripts in the repository and restructure this script accordingly.

@pranjalpatidar01
Copy link
Copy Markdown
Author

Hi @sankalp-sde , I’ve simplified the pandas build script structure and removed the multi-distro handling so that the script is now scoped specifically for UBI/RHEL 9.6 and aligned with the existing repository conventions. Could you please review again when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants