Add build script for pandas 2.2.3#84
Conversation
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
this file name is not proper, it should be build_info.json
|
@pranjalpatidar01 the PR needs multiple changes, please correct the file names, folder structure, script format. |
|
I’ve updated the PR with the requested changes:
|
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": "false", | ||
| "v0.2.*": { |
There was a problem hiding this comment.
this version should be v2.2.* to match the package version
|
@pranjalpatidar01 the script file is still not aligned as per the requirement. Please compare with existing scripts in this repo and update. |
|
Hi @namrata.bhave, I’ve updated the script and build_info.json to align with the existing repository conventions, corrected the naming/folder structure, and validated the build and test execution on UBI/RHEL 9.6 (s390x). Could you please review again when you get a chance. |
|
@pranjalpatidar01 Please update your script file to match the existing format. Refer to this example: build-scripts/a/async/async_ubi_9.3.sh Lines 4 to 11 in 28c87ac |
|
Hi @sankalp-sde , I’ve updated the pandas script header and formatting to align with the existing repository conventions and pushed the latest changes. Could you please review again when you get a chance. |
|
@pranjalpatidar01 The distro handling and overall script structure do not align with the repository conventions for platform-specific scripts. it should ideally be scoped to the intended target platform instead of handling multiple Ubuntu, RHEL, and SLES variants in the script Please refer to the existing scripts in the repository and restructure this script accordingly. |
|
Hi @sankalp-sde , I’ve simplified the pandas build script structure and removed the multi-distro handling so that the script is now scoped specifically for UBI/RHEL 9.6 and aligned with the existing repository conventions. Could you please review again when you get a chance. |
Summary
Added build script support for pandas 2.2.3.
Included files
Validation