Capture and display evmctl error messages and pass --v3 to evmctl when necessary#45
Open
stefanberger wants to merge 3 commits into
Open
Capture and display evmctl error messages and pass --v3 to evmctl when necessary#45stefanberger wants to merge 3 commits into
stefanberger wants to merge 3 commits into
Conversation
stefanberger
force-pushed
the
kernel_tests
branch
4 times, most recently
from
dc620d0 to
743b53f
Compare
Capture evmctl error message in err variable and display it if needed. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Pass --v3 to evmctl when ML-DSA keys are used for signing. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Increase the ext4 block size to 8kb to not run out of space when trying to write ML-DSA signatures. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
kernel_tests
branch
from
743b53f to
0aa3d6c
Compare
mimizohar
requested changes
Jun 22, 2026
Collaborator
There was a problem hiding this comment.
mkfs.ext4 fails with "8192-byte blocks too big for system (max 4096)" on most systems. An alternative would be to specify "-O ea_inode" on either the mkfs.ext4 or tune2fs commands.
mkfs.ext4 will pause and wait for user input - "Proceed anyway? (y,N)". In a non-interactive script, this causes the script to hang indefinitely. Possible solution is to pipe the letter "N" to the mkfs.ext4 command.
Please fix the mkfs.ext4 failure and how mkfs.ext4 handles failures.
mimizohar
requested changes
Jun 22, 2026
mimizohar
left a comment
mimizohar
left a comment
Collaborator
There was a problem hiding this comment.
In functions_kernel.sh, "err" is not defined as a local variable, nor displayed in this patch. Either define and use "err" or remove it from this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture and display evmctl error messages and pass --v3 to evmctl when ML-DSA keys are being used for signing.