Skip to content

fix: add --isolation alias#131

Merged
konard merged 2 commits into
mainfrom
issue-130-cefa8a965461
Jun 6, 2026
Merged

fix: add --isolation alias#131
konard merged 2 commits into
mainfrom
issue-130-cefa8a965461

Conversation

@konard

@konard konard commented Jun 6, 2026

Copy link
Copy Markdown
Member

Fixes #130.

Summary

  • Add --isolation and --isolation=<env> as aliases for --isolated in both JavaScript and Rust parsers.
  • Reject unknown dash-prefixed wrapper options before they can fall through to direct command execution.
  • Update help text, README docs, regression tests, case-study notes, and JS/Rust release metadata.

Reproduction

Before the fix, $ --isolation docker -- echo 'hi' parsed with no isolation request and ran directly. The new parser tests cover that command form plus --isolation=<env>, no-separator parsing, and unknown wrapper option failures.

Tests

  • bun test ./test/args-parser-isolation-alias.js
  • bun run test
  • bun run check
  • cargo test --all-features --verbose
  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features
  • node scripts/check-file-size.mjs
  • node scripts/check-test-parity.mjs
  • node scripts/check-doc-examples.mjs
  • bash scripts/check-mjs-syntax.sh
  • node scripts/validate-changeset.mjs
  • HAS_FRAGMENTS=true node scripts/check-release-needed.mjs --working-dir js --registry npm
  • HAS_FRAGMENTS=true node scripts/check-release-needed.mjs --working-dir rust --registry crates.io

No screenshots are included because this is CLI parser behavior.

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #130
@konard konard self-assigned this Jun 6, 2026
@konard konard changed the title [WIP] --isolation alias for --isolated fix: add --isolation alias Jun 6, 2026
@konard konard marked this pull request as ready for review June 6, 2026 23:42
@konard

konard commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

Working session summary

Implemented and pushed the fix to PR 131: #131

What changed:

  • Added --isolation and --isolation=<env> as aliases for --isolated in both JS and Rust parsers.
  • Unknown dash-prefixed wrapper options now fail fast instead of silently falling through to direct command execution.
  • Added regression tests, help/README updates, release metadata, and the issue case study under docs/case-studies/issue-130.

Verification:

  • Local JS/Rust checks passed, including bun run test, bun run check, cargo test --all-features --verbose, cargo fmt, and cargo clippy.
  • GitHub CI is green on commit 57c3fd4: JavaScript CI/CD and Rust CI/CD both completed successfully.
  • PR 131 is marked ready for review.
  • Working tree is clean.

This summary was automatically extracted from the AI working session output.

@konard

konard commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.5
  • Provider: OpenAI
  • Public pricing estimate: $11.374992

📊 Context and tokens usage:

  • 267.5K / 1.1M (25%) input tokens, 31.8K / 128K (25%) output tokens

Total: (267.5K + 7.3M cached) input tokens, 31.8K output tokens, $11.374992 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.5
  • Model: GPT-5.5 (gpt-5.5)

📎 Log file uploaded as Repository (39720KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard

konard commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard merged commit a35ba12 into main Jun 6, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--isolation alias for --isolated

1 participant