Update dependencies and bump to Rust 1.80 - #450
Conversation
This is actually rust-lang/rust-clippy#12856 But the code was a bit of a smell: `&&mut PathBuf`
Philipp-M
left a comment
Philipp-M
left a comment
There was a problem hiding this comment.
LGTM, but I'd probably change the title, such that it also reflects the other package updates
| # Remove assigning_clones once it's allowed by default in stable Rust | ||
| # https://github.com/rust-lang/rust-clippy/pull/12779 |
There was a problem hiding this comment.
Why all the comments (including below)?
There was a problem hiding this comment.
Oh seriously? I trusted cargo upgrade to actually do the right thing. That's incredibly annoying.
There was a problem hiding this comment.
Ok, that's a weird, probably open an issue in cargo upstream then?
There was a problem hiding this comment.
It's part of cargo-edit. I believe that the in-place toml editing doing stupid things with comments/ordering is known, although I can't find where it's tracked at the moment.
DJMcNab
changed the title
DJMcNab
changed the title
|
Why bundle the update to Rust with the other? (Just asking.) |
|
This is the policy we decided upon in linebender/rfcs#5 |
I believe he meant, why not separate PRs for package-updates and rust-version, but I think having all of this in one PR is good for me too, as those update changes seem to be largely uncontroversial/maintenance |
3 participants
There is one "semi-false-positive" lint triggered, which I have fixed.
Otherwise, the required