Skip to content

chore: use std assert_matches macro - #1837

Merged
PoignardAzur merged 5 commits into
linebender:mainfrom
Soundcreates:soundcreates/remove-assert-matches-dependency
Aug 24, 2026
Merged

chore: use std assert_matches macro#1837
PoignardAzur merged 5 commits into
linebender:mainfrom
Soundcreates:soundcreates/remove-assert-matches-dependency

Conversation

@Soundcreates

Copy link
Copy Markdown
Contributor

Fixes #1758.

Replace the external assert_matches dev-dependency with Rust's stabilized std::assert_matches! macro and remove the unused dependency declarations.

Tests: cargo test -p masonry_core -p masonry_testing -p masonry --no-default-features

@PoignardAzur

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

Remember to push the updated Cargo.lock.

@Soundcreates

Soundcreates commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

I updated and pushed the revised Cargo.lock in commit b5665a85.

@PoignardAzur

Copy link
Copy Markdown
Collaborator

Thanks.

This is effectively blocked on #1838.

@Soundcreates

Copy link
Copy Markdown
Contributor Author

Thanks.

This is effectively blocked on #1838.

Understood

@PoignardAzur

Copy link
Copy Markdown
Collaborator

You should be able to rebase and merge this.

@Soundcreates

Copy link
Copy Markdown
Contributor Author

Have updated the branch to be synced with main

@PoignardAzur

Copy link
Copy Markdown
Collaborator

Still need to fix the formatting.

@Soundcreates

Copy link
Copy Markdown
Contributor Author

Fixed the formatting issues with cargo fmt --all and pushed commit 788c3317. The targeted test suite passes: cargo test -p masonry_core -p masonry_testing -p masonry --no-default-features.

@PoignardAzur
PoignardAzur added this pull request to the merge queue Aug 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 23, 2026
@PoignardAzur
PoignardAzur added this pull request to the merge queue Aug 24, 2026
@DJMcNab

DJMcNab commented Aug 24, 2026

Copy link
Copy Markdown
Member

The CI changes in 6616c5e are a little bit surprising. Although I cannot remember why the original form was needed in the first place...

Merged via the queue into linebender:main with commit b345368 Aug 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop importing assert_matches crate

3 participants