Add kernelUnitLength support to feDiffuseLighting, feSpecularLighting, and feConvolveMatrix - #1127
Open
edco wants to merge 1 commit into
Open
Add kernelUnitLength support to feDiffuseLighting, feSpecularLighting, and feConvolveMatrix#1127edco wants to merge 1 commit into
edco wants to merge 1 commit into
Conversation
…, and feConvolveMatrix - Parse kernelUnitLength in crates/usvg/src/parser/filter.rs for DiffuseLighting, SpecularLighting, and ConvolveMatrix - Add kernel_unit_length field and accessors to usvg AST structs - Write kernelUnitLength attribute in crates/usvg/src/writer.rs - Implement resolution-independent differential step and bilinear sampling in resvg lighting and convolve_matrix filter primitives - Add unit and integration tests for kernelUnitLength parsing and rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements kernelUnitLength support to enable scale-independent lighting effects.
Fixes #840 if the SVG is updated to include
kernelUnitLength:(without kernelUnitLength in the SVG the current behaviour is not a bug, and remains unchanged)
Authored mostly by Gemini 3.7 Flash in Google Antigravity IDE.