Skip to content

Honour region subtags (again!) - #756

Merged
DJMcNab merged 6 commits into
linebender:mainfrom
DJMcNab:honourSubtags
Aug 27, 2026
Merged

Honour region subtags (again!)#756
DJMcNab merged 6 commits into
linebender:mainfrom
DJMcNab:honourSubtags

Conversation

@DJMcNab

@DJMcNab DJMcNab commented Aug 26, 2026

Copy link
Copy Markdown
Member

LLM Contributions: Sonnet 5. Plus from Taj: Regression testing, CI changes (GPT 5.5 Sol) [Sic].

Fixes #748. All code is taken from #749, but with changes around how test font files are produced (plus taking care to document the license). See #parley > Test font files.

Table taken from Taj's PR.

Before After
Subtag not honoured (same glyphs throughout) Subtag honoured
before_subtag after_subtag

Changelog

Fixed

  • Honours script and region sub tags for correct shaping of, for example, zh-Hans and zh-Hant.

@DJMcNab DJMcNab mentioned this pull request Aug 26, 2026

@nicoburns nicoburns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DJMcNab
DJMcNab requested a review from taj-p August 26, 2026 12:34
```

If in adding future tests you need more glyphs, then replacing the current subset is fine, so long as this doc is updated.
Note that .

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I need to fix this! What's a neat way to say that "replacing the current subset is fine because it's only 3kb, but we'll need to rethink if it ends up being over 100kb?"

@taj-p taj-p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@DJMcNab
DJMcNab enabled auto-merge August 27, 2026 00:00
@DJMcNab
DJMcNab added this pull request to the merge queue Aug 27, 2026
Merged via the queue into linebender:main with commit 1eaefea Aug 27, 2026
47 of 48 checks passed
@DJMcNab
DJMcNab deleted the honourSubtags branch August 27, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shaping drops script/region subtags, so zh-Hans and zh-Hant select the same OpenType langsys

3 participants