Fix infinite loop in break_remaining with CustomOutOfFlow inline boxes - #753
Merged
nicoburns merged 2 commits intoAug 18, 2026
Merged
Conversation
break_next yields on CustomOutOfFlow boxes without advancing past them, leaving placement to the caller. break_remaining ignored these yields, so it would loop forever. Advance past the box as zero-sized out-of-flow content instead. Fixes linebender#752
taj-p
approved these changes
Aug 18, 2026
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
fix-752-break-remaining-custom-oof
branch
from
August 18, 2026 21:47
564a16c to
ad19e04
Compare
nicoburns
enabled auto-merge
August 18, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix infinite loop in
break_remainingwithCustomOutOfFlowinline boxes.break_nextyields onCustomOutOfFlow, boxes without advancing past them, so ifbreak_remainingignores these yields (as it currently does), it will loop forever withbreak_nextcontinually returning the same box.Fix: Advance past the box as zero-sized out-of-flow content instead.
Fixes #752
LLM Contributions: Fix generated with Devin Ultra.
No changelog entry because this will get backported as 0.11.2. Changelog added on v0.11.x branch and then forward-ported to
main.