Skip to content

Use the correct family ID when adding font aliases #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valadaptive merged 2 commits into from
Jun 13, 2025
Merged

Use the correct family ID when adding font aliases #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d079c
Use the correct family ID when adding font aliases
valadaptive Jun 13, 2025
3e105c4
Add family ID fix to `CHANGELOG.md`
valadaptive Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ This release has an [MSRV] of 1.82.

### Fixed

#### Fontique

- Font family name aliases (secondary names for font families, often in another language) not being registered. ([#380][] by [@valadaptive][])

## [0.5.0] - 2025-06-01

This release has an [MSRV] of 1.82.
Expand Down Expand Up @@ -292,6 +296,7 @@ This release has an [MSRV][] of 1.70.
[#353]: https://github.com/linebender/parley/pull/353
[#362]: https://github.com/linebender/parley/pull/362
[#369]: https://github.com/linebender/parley/pull/369
[#380]: https://github.com/linebender/parley/pull/380

[Unreleased]: https://github.com/linebender/parley/compare/v0.5.0...HEAD
[0.5.0]: https://github.com/linebender/parley/compare/v0.4.0...v0.5.0
Expand Down
2 changes: 1 addition & 1 deletion fontique/src/family_name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ impl FamilyNameMap {
}
let new_name = FamilyName {
name: name.into(),
id: FamilyId::new(),
id,
};
self.name_map.insert(key.as_bytes().into(), new_name);
Comment thread
valadaptive marked this conversation as resolved.
}
Expand Down