Fix dangling libm link when building docs without the libm feature - #333
Merged
Conversation
Signed-off-by: David Anderson <dave@natulte.net>
DJMcNab
approved these changes
Aug 16, 2026
DJMcNab
left a comment
DJMcNab
left a comment
Member
There was a problem hiding this comment.
Yeah - cargo rmde doesn't understand cfg flags (at least, the 1.x series)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked that
cargo docwith and without the libm feature builds without warnings.The README.md didn't change when regenerated by
cargo rdme, which surprised me slightly. But looking at the readme, it has a block of explicit links outside of the generated section that fixes up libm references already, so no change needed there.(extracted from #330 after feedback from @DJMcNab, thank you!)