Add f64s and mask64s associated types - #125
Merged
Merged
Conversation
DJMcNab
reviewed
Nov 14, 2025
Contributor
Author
|
This has been rebased and can be approved now. |
DJMcNab
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #123 since it touches the same code.
Adding 64-bit integer types is tricky because SSE4.2 and AVX2 are missing some important 64-bit operations, and I don't feel comfortable implementing those until #124 is addressed. However, we already have
mask64x[N]andf64x[N]types.The
f32sassociated type has aBytes = <Self::u32s as Bytes>::Bytesconstraint, which misled me into thinking that a float type needs an associated int type, but that constraint is only there to assert that the two share the sameBytestype.