Store view regions in undo history#132
Open
darshan-Jahagirdar wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
This stores a deep snapshot of the view region map at edit start and edit end, then restores the correct snapshot during undo/redo. Selection restoration now uses the same snapshot path, and glued undo entries preserve the first saved region state plus the final current state.
Validation:
TestUndoStackRestoresViewRegionscovering named regions across edit, undo, and redo.git diff --checkpasses.go test ./render ./clipboard ./keys ./logpasses locally.Could not run the backend package tests on this Windows environment because the existing TextMate/rubex dependency fails to build with CGO disabled (
undefined: rubex.Regexp,rubex.CompileWithOption). Existing watcher/package tests also fail on Windows file watcher setup withThe parameter is incorrect.Bounty: targets the $15 Bountysource bounty linked from #101.