Skip to content

feat(settings): accessibility section#160

Open
Lorchie wants to merge 2 commits into
devfrom
feat/accessibility
Open

feat(settings): accessibility section#160
Lorchie wants to merge 2 commits into
devfrom
feat/accessibility

Conversation

@Lorchie
Copy link
Copy Markdown
Collaborator

@Lorchie Lorchie commented Jun 1, 2026

No description provided.

@Lorchie Lorchie force-pushed the feat/accessibility branch from 7596e6a to 820741c Compare June 1, 2026 18:54
@lightningpixel
Copy link
Copy Markdown
Owner

  1. TextSize is defined twice

App.tsx redefines a type that is already used inline in appStore.ts:

// App.tsx — should not be here
type TextSize = 'small' | 'medium' | 'large'
Export the type from appStore.ts and import it in App.tsx. That also removes the need for the as TextSize cast on the next line, which is only there to work around the duplication.

  1. Missing type="button" on SegmentedControl buttons

In ui/index.tsx, the elements have no explicit type. Browsers default to type="submit" inside a form, which would trigger an unintended submission. Add type="button" to each one.

  1. SegmentedControl has no ARIA attributes — ironic for an Accessibility section

The component has no semantic markup for assistive technologies:

The container should have role="group" and accept an aria-label prop (e.g. "Text size")
Each active button should have aria-pressed={active}
4. Import alignment in SettingsPage.tsx

The extra spaces added to align the existing imports are not consistent with the rest of the file. Either apply it everywhere or remove it — as-is it just adds noise to the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants