Skip to content

fix: handle single-signer case in MuSig2Sign #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Olexandr88 wants to merge 1 commit into from
Closed

fix: handle single-signer case in MuSig2Sign #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/musig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func MuSig2Sign(version input.MuSig2Version, privKeys []*btcec.PrivateKey,

// Now that we have all partial sigs we can just combine them to
// get the final signature.
var haveAllSigs bool
haveAllSigs := len(signatures) == 1
Copy link
Copy Markdown
Collaborator

@starius starius Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lnd/input does not allow a single signer use-case in musig2, so this patch is wrong.

I addressed the finding another way in #1110

Copy link
Copy Markdown
Author

@Olexandr88 Olexandr88 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification

for i := 1; i < len(signatures); i++ {
var err error
haveAllSigs, err = input.MuSig2CombineSig(
Expand Down