Add OpenChannel::disable_counterparty_reserve#187
Merged
benthecarman merged 2 commits intolightningdevkit:mainfrom Apr 15, 2026
Merged
Add OpenChannel::disable_counterparty_reserve#187benthecarman merged 2 commits intolightningdevkit:mainfrom
OpenChannel::disable_counterparty_reserve#187benthecarman merged 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
533b050 to
3a90bde
Compare
| announce_channel: bool, | ||
| #[arg( | ||
| long, | ||
| help = "Allow the counterparty to spend all its channel balance. This cannot be set together with `announce_channel`." |
Collaborator
There was a problem hiding this comment.
can we enforce the cannot set together with announce_channel on the cli side too
When set, the counterparty will be allowed to spend its entire balance in the channel. This setting cannot be set together with `announce_channel`.
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
3a90bde to
2c0e186
Compare
benthecarman
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When set, the counterparty will be allowed to spend its entire balance in the channel.
This setting cannot be set together with
announce_channel.