Conversation
✅ Deploy Preview for courageous-frangipane-fab648 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jbesraa
force-pushed
the
add-2829-part-1
branch
2 times, most recently
from
56bc703 to
2d428f8
Compare
|
Nice. I like the addition of the bLIP review. I do think we could expand on the questions to cover more detail and specifics, though. I'll review and give them some thought. If you have any additional specific questions in mind then it would be great to add some! We could dive deeper into the implementation itself. |
jbesraa
force-pushed
the
add-2829-part-1
branch
from
2d428f8 to
65c01a3
Compare
Added another question, and I have a couple of follow up questions if the audience will be engaging enough. |
Ok great! Just a few review comments then I'll merge today! |
| @@ -0,0 +1,31 @@ | |||
| --- | |||
| layout: pr | |||
| date: 2024-02-16 | |||
There was a problem hiding this comment.
Looks like this needs to be update.
| ## Questions | ||
| 1. Did you review bLIP31? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
| 2. What are the capabilities [bLIP/31] introduce? | ||
| 3. Who initiae the messaging process? what are the pros/cons? |
|
|
||
| ## Questions | ||
| 1. Did you review bLIP31? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
| 2. What are the capabilities [bLIP/31] introduce? |
| 1. Did you review bLIP31? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
| 2. What are the capabilities [bLIP/31] introduce? | ||
| 3. Who initiae the messaging process? what are the pros/cons? |
| 2. What are the capabilities [bLIP/31] introduce? | ||
| 3. Who initiae the messaging process? what are the pros/cons? | ||
| 4. How does [bLIP/31] relate to [bolt/11] and [bolt/12]? | ||
| 5. How the message sender know they are able to exchange a message with the recipient? |
jbesraa
force-pushed
the
add-2829-part-1
branch
from
65c01a3 to
7a6344a
Compare
|
@jkczyz thanks! |
|
Oof my reviews were still "pending" as I forgot to hit submit but @jkczyz got all of them 🤦♂️ |
|
Ah no worries! Thanks for merging. In the next few days ill open part 2 of this. In the next couple of sessions after that, gonna cover the new dns bLIP. |
3 participants
No description provided.