Skip to content

fix: use $esbuild reference in overrides to resolve npm EOVERRIDE - #40

Open
reednaa wants to merge 1 commit into
mainfrom
fix/esbuild-override
Open

fix: use $esbuild reference in overrides to resolve npm EOVERRIDE#40
reednaa wants to merge 1 commit into
mainfrom
fix/esbuild-override

Conversation

@reednaa

@reednaa reednaa commented Jul 23, 2026

Copy link
Copy Markdown
Member

npm publish failed with EOVERRIDE because the esbuild override (0.28.1) did not exactly match the direct devDependency spec (^0.28.1). Using the $esbuild reference keeps the transitive pin in sync with the direct dependency automatically.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the esbuild dependency override to stay aligned with the project’s configured version.

npm publish failed because the esbuild override (0.28.1) did not exactly
match the direct devDependency spec (^0.28.1). The $esbuild reference
keeps the transitive pin in sync with the direct dependency.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 53bf798c-bf1d-465b-9ea6-1c54d40415f6

📥 Commits

Reviewing files that changed from the base of the PR and between bc486a4 and 3a787f4.

📒 Files selected for processing (1)
  • typescript/package.json

📝 Walkthrough

Walkthrough

The TypeScript package configuration changes the esbuild override from pinned version 0.28.1 to the $esbuild package reference.

Changes

esbuild override

Layer / File(s) Summary
Use package esbuild reference
typescript/package.json
The overrides.esbuild value now uses $esbuild instead of the fixed 0.28.1 version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching the esbuild override to $esbuild to fix npm EOVERRIDE.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/esbuild-override

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
typescript/package.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a787f4909

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread typescript/package.json
"overrides": {
"axios": "1.18.1",
"esbuild": "0.28.1",
"esbuild": "$esbuild",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate the Bun lockfile for the new override

Changing this override leaves typescript/bun.lock recording "esbuild": "0.28.1", while Bun resolves $esbuild to the direct dependency specification ^0.28.1. Consequently, the bun install --frozen-lockfile step in .github/workflows/bun-test.yml rejects the committed lockfile as changed, blocking the TypeScript CI job; regenerate and commit bun.lock with this package change.

AGENTS.md reference: AGENTS.md:L16-L20

Useful? React with 👍 / 👎.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.09%. Comparing base (bc486a4) to head (3a787f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   94.37%   94.09%   -0.28%     
==========================================
  Files          43       27      -16     
  Lines        3325     2898     -427     
  Branches       44        0      -44     
==========================================
- Hits         3138     2727     -411     
+ Misses        187      171      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants