fix: use $esbuild reference in overrides to resolve npm EOVERRIDE - #40
fix: use $esbuild reference in overrides to resolve npm EOVERRIDE#40reednaa wants to merge 1 commit into
Conversation
npm publish failed because the esbuild override (0.28.1) did not exactly match the direct devDependency spec (^0.28.1). The $esbuild reference keeps the transitive pin in sync with the direct dependency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TypeScript package configuration changes the Changesesbuild override
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)typescript/package.jsonTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a787f4909
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "overrides": { | ||
| "axios": "1.18.1", | ||
| "esbuild": "0.28.1", | ||
| "esbuild": "$esbuild", |
There was a problem hiding this comment.
Regenerate the Bun lockfile for the new override
Changing this override leaves typescript/bun.lock recording "esbuild": "0.28.1", while Bun resolves $esbuild to the direct dependency specification ^0.28.1. Consequently, the bun install --frozen-lockfile step in .github/workflows/bun-test.yml rejects the committed lockfile as changed, blocking the TypeScript CI job; regenerate and commit bun.lock with this package change.
AGENTS.md reference: AGENTS.md:L16-L20
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 94.37% 94.09% -0.28%
==========================================
Files 43 27 -16
Lines 3325 2898 -427
Branches 44 0 -44
==========================================
- Hits 3138 2727 -411
+ Misses 187 171 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
npm publish failed with
EOVERRIDEbecause theesbuildoverride (0.28.1) did not exactly match the direct devDependency spec (^0.28.1). Using the$esbuildreference keeps the transitive pin in sync with the direct dependency automatically.🤖 Generated with Claude Code
Summary by CodeRabbit