test(cli): make stale-port status fixture deterministic - #3980
Conversation
(cherry picked from commit 8137b9e)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 47 / 80이 PR은 라인 tests/cli/cli-status-json.test.ts · allocateFreePort - listen(0)으로 ephemeral port를 잡고 바로 close합니다. 공유 freePort 전역을 없앱니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…lback test (#4053) * test(cli): make stale-port status fixture deterministic Carried from #3980 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * refactor(router): isolate API-key selection capture Carried from #3897 (author parkjs101) for maintainer-side CI and sequential integration. Closes #3894 Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> * docs: retire the historical dashboard capture pack Carried from #3963 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * refactor(gui): stabilize model feedback callback dependencies Carried from #3984 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * test(gui): pin the publishFeedback callback identity #3984 changes publishFeedback to a useCallback and adds it to saveDisplayName's dependency array, but shipped without coverage, so the hygiene gate flags missing_regression_test. This source-oracle test asserts both halves and fails on dev without the fix (0 pass / 2 fail), so the suppression cannot come back unnoticed. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * chore(assets): file the #3984 screenshot with the others #3984 added its review screenshot under a new assets/pr-screenshots/ directory. The repository's nineteen existing PR screenshots all live in docs-site/public/pr-screenshots/, so this moves it there and keeps the new top-level directory out of the tree. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> --------- Co-authored-by: t <a@b.com> Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
|
Landed on Verification at the merged head Closing this PR because the change is already on |
Summary
Allocate the refused runtime-record port after binding the deliberately occupied configured-port listener, and assert the two ports differ. Reallocate per test so the occupied listener cannot reuse a previously released shared port and silently invert the fixture.
Test fixture only; no user documentation change needed.
Verification
bun test tests/cli/cli-status-json.test.ts: 47 passed.All runtime checks used a fresh temporary OPENCODEX_HOME and alternate port; production config fingerprint and backup inventory remained unchanged. Full root-suite and review-readiness gates have not been completed for this head; this is intentionally a draft.
Checklist
Review readiness
Co-authored-by: SB Yoon 44089734+yansigit@users.noreply.github.com
Co-authored-by: Yumi automation@sbyoon.com
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.