docs: retire the historical dashboard capture pack - #3963
Closed
luvs01 wants to merge 1 commit into
Closed
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (28)
📒 Files selected for processing (34)
💤 Files with no reviewable changes (32)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR removes dashboard capture assets and updates the inventory and reviewer notes to describe the temporary evidence packet. The route inventory retains source, control, and text counts while removing screenshot references. ChangesDashboard evidence cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes historical dashboard captures and updates their documentation without changing application behavior, configuration, or runtime code. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
documentation
Contributor
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This PR stays in draft until every box above is ticked. Hygiene✅ Deterministic PR hygiene checks passed. |
Contributor
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Owner
리뷰 · 우선순위 38 / 80이 PR은 역사 문서 유닛 지금 경로 60개 assets 삭제 - Git 히스토리의 바이너리는 그대로 남습니다. PR 본문도 “히스토리까지 지우지 않는다”고 명시했습니다. 트리에서만 빼는 목표와 맞습니다. 경로 000_inventory.md - 스크린샷 열 제거 후에도 17행의 네 핵심 열이 그대로인지 diff로 확인했다고 합니다. 머지 전 그 주장만 한 번 더 눈으로 보면 됩니다. 경로 draft - ready 표시와 CI(문서 전용) 확인 전에는 머지 큐에 올리지 않는 편이 낫습니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
luvs01
force-pushed
the
agent/dashboard-capture-retention-20260908
branch
from
September 8, 2026 02:06
29a69c9 to
438e2d0
Compare
luvs01
force-pushed
the
agent/dashboard-capture-retention-20260908
branch
from
September 8, 2026 07:44
438e2d0 to
5497cd9
Compare
Contributor
Author
|
@coderabbitai review Please review current head |
Contributor
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
head='5497cd9943c4b4c26e7b99926d9f0725b16f1cce'
base='74f62f9c2914ead2fba474aa97734e322251bd46'
unit='devlog/_plan/260904_dashboard_minimal'
echo '== Commit identity and ancestry =='
git show -s --format='HEAD %H%nParents %P%nSubject %s' "$head"
git merge-base --is-ancestor "$base" "$head" && echo "BASE_IS_ANCESTOR=yes" || echo "BASE_IS_ANCESTOR=no"
git diff-tree --no-commit-id --name-status -r "$head"
echo
echo '== Change summary against stated base =='
git diff --stat "$base" "$head"
echo '-- changed paths --'
git diff --name-status "$base" "$head"
echo
echo '== Current unit tree =='
fd . "$unit" --type f | sort
echo
echo '== Edited Markdown diff with line context =='
git diff --unified=80 "$base" "$head" -- \
"$unit/000_inventory.md" \
"$unit/001_subagent_opinions.md"
echo
echo '== Current Markdown files with line numbers =='
for f in "$unit/000_inventory.md" "$unit/001_subagent_opinions.md"; do
echo "-- $f --"
nl -ba "$f"
done
echo
echo '== Deleted asset count and remaining current assets =='
deleted_assets=$(git diff --name-only --diff-filter=D "$base" "$head" -- "$unit/assets" | wc -l)
printf 'deleted_assets=%s\n' "$deleted_assets"
if test -d "$unit/assets"; then
fd . "$unit/assets" --type f | sort
else
echo 'assets_directory_absent=yes'
fi
echo
echo '== References to deleted asset basenames outside deleted files =='
tmp=$(mktemp)
git diff --name-only --diff-filter=D "$base" "$head" -- "$unit/assets" |
xargs -r -n1 basename > "$tmp"
while IFS= read -r asset; do
rg -n -F --glob '!devlog/_plan/260904_dashboard_minimal/assets/**' -- "$asset" . || true
done < "$tmp"
rm -f "$tmp"
echo
echo '== Markdown links targeting the retired assets directory =='
rg -n -P '\]\([^)]*260904_dashboard_minimal/assets|260904_dashboard_minimal/assets/' --glob '*.md' . || trueLength of output: 31770 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='5497cd9943c4b4c26e7b99926d9f0725b16f1cce'
base='74f62f9c2914ead2fba474aa97734e322251bd46'
unit='devlog/_plan/260904_dashboard_minimal'
echo '== Complete edited Markdown files with line numbers =='
for f in "$unit/000_inventory.md" "$unit/001_subagent_opinions.md"; do
echo "-- $f --"
awk '{ printf "%6d %s\n", NR, $0 }' "$f"
done
echo
echo '== Deleted asset count, types, and byte total =='
git diff --name-only --diff-filter=D "$base" "$head" -- "$unit/assets/" > /tmp/deleted-dashboard-assets.txt
printf 'deleted_asset_count='
wc -l < /tmp/deleted-dashboard-assets.txt
printf 'deleted_png_count='
grep -Ec '\.png$' /tmp/deleted-dashboard-assets.txt || true
printf 'deleted_text_snapshot_count='
grep -Ec '\.txt$' /tmp/deleted-dashboard-assets.txt || true
git diff --numstat "$base" "$head" -- "$unit/assets/" |
awk -F '\t' '
$1 == "-" && $2 == "-" { next }
{ added += $1; deleted += $2 }
END { printf "deleted_text_lines=%d\n", deleted }'
echo
echo '== Deleted binary byte total from base tree =='
git ls-tree -rl "$base" -- "$unit/assets/" |
awk '{sum += $4} END {printf "deleted_base_bytes=%d\n", sum}'
echo
echo '== Remaining unit references to retired asset names =='
while IFS= read -r asset_path; do
asset_name=${asset_path##*/}
matches=$(grep -RInF --exclude-dir=assets -- "$asset_name" "$unit" || true)
if [ -n "$matches" ]; then
printf '%s\n' "$matches"
fi
done < /tmp/deleted-dashboard-assets.txt
echo
echo '== Repository Markdown references to retired assets directory =='
grep -RInE --include='*.md' \
'260904_dashboard_minimal/assets/|assets/[[:alnum:]_.-]+_(1440|text|interactive)\.(png|txt)' \
. || true
echo
echo '== Markdown inline-link destinations that no longer exist =='
python3 - <<'PY'
import os, re
root = os.getcwd()
for directory, _, files in os.walk(root):
if '/.git' in directory:
continue
for name in files:
if not name.endswith('.md'):
continue
path = os.path.join(directory, name)
try:
text = open(path, encoding='utf-8').read()
except UnicodeDecodeError:
continue
for line_no, line in enumerate(text.splitlines(), 1):
for target in re.findall(r'\]\(([^ )#]+)', line):
if '://' in target or target.startswith(('mailto:', '#')):
continue
candidate = os.path.normpath(os.path.join(directory, target))
if not os.path.exists(candidate):
print(f'{os.path.relpath(path, root)}:{line_no}: missing target: {target}')
PYLength of output: 203150 🏁 Script executed: #!/bin/bash
set -euo pipefail
head='5497cd9943c4b4c26e7b99926d9f0725b16f1cce'
base='74f62f9c2914ead2fba474aa97734e322251bd46'
unit='devlog/_plan/260904_dashboard_minimal'
prior_log='/tmp/coderabbit-shell-logs/shell-output-JAQFs0'
echo '== Prior-log sections before the broad link heuristic =='
sed -n '1,/== Markdown inline-link destinations that no longer exist ==/p' "$prior_log"
echo
echo '== Changed lines only =='
git diff --unified=0 "$base" "$head" -- \
"$unit/000_inventory.md" \
"$unit/001_subagent_opinions.md"
echo
echo '== Inventory table validation =='
awk '
/^\| Route \| Source \| Interactive \| Words \|$/ { in_table=1; next }
in_table && /^\|---\|---\|---\|---\|$/ { next }
in_table && /^\|/ {
rows++
pipes=gsub(/\|/, "&")
if (pipes != 5) invalid++
next
}
in_table { in_table=0 }
END {
printf "inventory_data_rows=%d\n", rows
printf "rows_with_invalid_column_count=%d\n", invalid
}
' "$unit/000_inventory.md"
echo
echo '== References to each deleted asset outside the deleted directory =='
git diff --name-only --diff-filter=D "$base" "$head" -- "$unit/assets/" |
while IFS= read -r deleted; do
name=${deleted##*/}
grep -RInF --exclude-dir=assets -- "$name" "$unit" || true
done
echo
echo '== Links to deleted unit assets in the current tree =='
grep -RInE --include='*.md' \
'(260904_dashboard_minimal/)?assets/[^ )]+(\.png|\.txt)' \
"$unit" .github README.md docs-site 2>/dev/null || true
echo
echo '== Current assets directory status =='
if test -e "$unit/assets"; then
echo 'assets_path_exists=yes'
find "$unit/assets" -type f -print
else
echo 'assets_path_exists=no'
fiLength of output: 149613
No findings. The commit is directly based on
The hosted contributor CI remains pending and is the remaining merge gate.
|
3 tasks
lidge-jun
added a commit
that referenced
this pull request
Sep 8, 2026
…lback test (#4053) * test(cli): make stale-port status fixture deterministic Carried from #3980 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * refactor(router): isolate API-key selection capture Carried from #3897 (author parkjs101) for maintainer-side CI and sequential integration. Closes #3894 Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> * docs: retire the historical dashboard capture pack Carried from #3963 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * refactor(gui): stabilize model feedback callback dependencies Carried from #3984 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * test(gui): pin the publishFeedback callback identity #3984 changes publishFeedback to a useCallback and adds it to saveDisplayName's dependency array, but shipped without coverage, so the hygiene gate flags missing_regression_test. This source-oracle test asserts both halves and fails on dev without the fix (0 pass / 2 fail), so the suppression cannot come back unnoticed. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * chore(assets): file the #3984 screenshot with the others #3984 added its review screenshot under a new assets/pr-screenshots/ directory. The repository's nineteen existing PR screenshots all live in docs-site/public/pr-screenshots/, so this moves it there and keeps the new top-level directory out of the tree. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> --------- Co-authored-by: t <a@b.com> Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
Owner
|
Landed on Verification at the merged head Closing this PR because the change is already on |
Owner
lidge-jun
added
the
landed-via-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The historical
260904_dashboard_minimalreview unit retains a live dashboard capture pack after its inventory and review conclusions were recorded. Retire the pack from the current tree: 28 PNG captures and 32 visible-text/interactive-control snapshots, totaling 4,513,616 bytes. The raw captures are unnecessary for the retained source inventory and review conclusions; this change does not assert that every capture contains sensitive information or remove Git history.Update only the unit's inventory and review introduction. Preserve every route, source reference, control count, word count and original reviewer conclusion. Keep the Korean/1440-pixel capture conditions and the distinction between Storage's mid-scan skeleton and its source-based inventory. Remove the obsolete screenshot column; explain that bare filenames quoted in the reviewers' original reasoning are historical references, not current assets.
The 62-file scope is one historical documentation unit: 60 asset deletions and two Markdown edits. It contains no dashboard implementation, runtime, configuration, package or test changes.
Verification
dev74f62f9c2914ead2fba474aa97734e322251bd46; head5497cd9943c4b4c26e7b99926d9f0725b16f1cce. The historical unit's upstream contents did not change; both edited Markdown files retain identical bytes and all 60 retired assets remain absent after rebase.assets/references. Historical bare filenames in reviewer reasoning remain deliberately documented.git diff --checkand the repository privacy scanner passed on the rebased head. The sparse checkout includes the changed Markdown, source, scripts and documentation; omitted unrelated files are outside this local scan. Images and raw text captures were not opened or displayed.bun run --cwd docs-site buildpassed on the rebased head and produced 425 pages in 32.94 seconds.Checklist
Review readiness checklist
Summary by CodeRabbit
Documentation
Chores