chore: update quic-go to v0.61.0 - #3530
Closed
lidel wants to merge 1 commit into
Closed
Conversation
quic-go v0.61.0 replaced http3.ParseCapsule with the stateful CapsuleParser API, and every tagged webtransport-go release still calls the old one. The port landed in quic-go/webtransport-go#323 but is not in a tagged release yet, so webtransport-go moves to that master commit, which in turn requires quic-go v0.61.0. - webtransport: rename the dialer type, since webtransport-go master renamed Dialer to Transport in quic-go/webtransport-go#343 - test-plans: retidy alongside the root module
Member
|
let's wait for webtransport-go to make a new release? Till then let's use v0.60 quic-go? |
Member
Author
|
Ack, opened #3532 with that approach. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This feels like a minefield, interfaces changed, abstraction changed, and things may required deeper refactor.
Not adopted here:
ClientConnsession pooling (quic-go/webtransport-go#344) and flow-control config (quic-go/webtransport-go#340). Both are behavior changes and neither is in a tagged release, nor wired in this PR.Opening this only for illustration purpose.
I'll open second PR which uses last "stable" release of webtransport-go instead.
Problem
quic-go v0.61.0 replaced
http3.ParseCapsulewith the statefulCapsuleParserAPI (quic-go/quic-go#5729), and every tagged webtransport-go release still calls the old one (lol?). No tagged webtransport-go builds against it.Fix
23b4cd1, which carries the port from update quic-go to v0.61.0, use the new capsule API quic-go/webtransport-go#323. That commit requires quic-go v0.61.0 itself, so the untagged pin rests on a real release rather than another pseudo-version.DialertoTransport(rename the Dialer to Transport quic-go/webtransport-go#343).Transport.initandClosebehave exactly asDialerdid, so no lifecycle change.TestDialWorkerLoopTCPConnUpgradeWaitand theholepunchsimnet panic fail on unmodified master too, 3/3 runs each, so they are not from this bump.Once webtransport-go tags a release with the capsule port, this drops back to an ordinary version bump.