Add safeguard to CUDA runtime bindings for device initialization#100
Open
asindarov wants to merge 1 commit into
Open
Add safeguard to CUDA runtime bindings for device initialization#100asindarov wants to merge 1 commit into
asindarov wants to merge 1 commit into
Conversation
| shared static this() | ||
| { | ||
| _initPlatform(); | ||
| if (__dcompute_reflect(ReflectTarget.CUDA,0)) { |
Collaborator
There was a problem hiding this comment.
hmm, does this work?
Pretty sure this will always be false for host code.
Author
There was a problem hiding this comment.
yes it worked on my mac, I don't have computer with nvidia chip, therefore cannot check the true case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this PR fixes silent failure on hardware that does not have CUDA device.