Consolidate erfa.core.STATUS_CODES definition - #316
Merged
Conversation
`STATUS_CODES` is the `dict` that contains possible status code values ERFA functions can return together with their descriptions extracted from the ERFA doc comments. So far `erfa_generator` has produced a `core.py` file that initialized `STATUS_CODES` as an empty `dict` to which entries were added one function at a time, meaning its contents have been spread out across almost 20 000 lines. Now `erfa_generator` produces code that creates `STATUS_CODES` in one go.
avalentino
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STATUS_CODESis thedictthat contains possible status code values ERFA functions can return together with their descriptions extracted from the ERFA doc comments. On currentmainerfa_generatorproduces acore.pyfile that initializesSTATUS_CODESas an emptydictto which entries are added one function at a time, meaning its contents are spread out across almost 20 000 lines. In this PRerfa_generatorproduces code that createsSTATUS_CODESin one go. The change is only to howSTATUS_CODESgets populated, there are no changes to the entries themselves.